Make onSelect works also for object keys#101
Merged
Kikobeats merged 10 commits intomicrolinkhq:masterfrom Mar 5, 2026
Merged
Conversation
|
@andres-artunduaga is attempting to deploy a commit to the Microlink Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
@andres-artunduaga thanks, can you add it as part of the demo? 🙏 |
Member
|
@cursor review |
Member
|
@andres-artunduaga argg something is broken, can you take a look? 🙏 |
Contributor
Author
|
@Kikobeats I've noticed some linting errors during the push process. I've sent a few commits to resolve these. This should keep the code without lint issues for future contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for reviewing this.
Sending code to cover #82
1. Key Click Selection Behavior
onSelect, not only value clicks.ArrayGroup,JsonObject,ObjectName, andVariableEditor.2. Lint and Test Cleanup
3. Unit Test Assertion Follow-up
JsonObjectunit test assertion for expanded icon count after test fixture normalization.